refacto: move is completed and isDisposable on package status helper

src/app/shared/enums/business/package-status.enum.ts

@@ -25,10 +25,18 @@ export enum PackageStatusEnum {
   DISPOSED = "DISPOSED",
   REPLICATING_TOMBSTONE = "REPLICATING_TOMBSTONE",
   REPLICATING_PACKAGE = "REPLICATING_PACKAGE",
-  UPDATING_RETENTION  = "UPDATING_RETENTION"
+  UPDATING_RETENTION = "UPDATING_RETENTION"
 }
 
 export class PackageStatusEnumHelper {
+  static isCompleted(status: PackageStatusEnum): boolean {
+    return (status === PackageStatusEnum.COMPLETED || status === PackageStatusEnum.DISPOSED);
+  }
+
+  static isDisposable(status: PackageStatusEnum): boolean {
+    return (status === PackageStatusEnum.DISPOSABLE);
+  }
+
   static getListKeyValue(): KeyValue[] {
     return [
       {

src/app/shared/features/aip/components/routables/aip-detail-edit/shared-aip-detail-edit.routable.ts

@@ -24,7 +24,10 @@ import {
 } from "@ngxs/store";
 import {SharedHistoryDialog} from "@shared/components/dialogs/shared-history/shared-history.dialog";
 import {SharedAbstractDetailEditCommonRoutable} from "@shared/components/routables/shared-abstract-detail-edit-common/shared-abstract-detail-edit-common.routable";
-import {PackageStatusEnum} from "@shared/enums/business/package-status.enum";
+import {
+  PackageStatusEnum,
+  PackageStatusEnumHelper,
+} from "@shared/enums/business/package-status.enum";
 import {IconNameEnum} from "@shared/enums/icon-name.enum";
 import {LocalStateEnum} from "@shared/enums/local-state.enum";
 import {
@@ -113,7 +116,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.simpleChecksum,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.simpleChecksum(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.simpleCheck"),
       order: 40,
@@ -122,7 +125,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.doubleChecksum,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.deepChecksum(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.deepCheck"),
       order: 40,
@@ -130,7 +133,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.reindex,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.reIndex(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.reindex"),
       order: 40,
@@ -138,7 +141,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.check,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.check(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.check"),
       order: 40,
@@ -146,7 +149,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.dispose,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.dispose(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.dispose"),
       order: 40,
@@ -178,7 +181,7 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
     {
       color: "primary",
       icon: IconNameEnum.download,
-      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && this.isCompleted(current.info.status),
+      displayCondition: current => this.mode !== AipMode.AIP_STEWARD && !isNullOrUndefined(current) && !isNullOrUndefined(current.info) && PackageStatusEnumHelper.isCompleted(current.info.status as PackageStatusEnum),
       callback: () => this.download(),
       labelToTranslate: (current) => MARK_AS_TRANSLATABLE("app.navigation.button.download"),
       order: 40,
@@ -228,14 +231,6 @@ export class SharedAipDetailEditRoutable extends SharedAbstractDetailEditCommonR
   getSubResourceWithParentId(id: string): void {
   }
 
-  isCompleted(status: string): boolean {
-    return (status === PackageStatusEnum.COMPLETED || status === PackageStatusEnum.DISPOSED);
-  }
-
-  isDisposable(status: string): boolean {
-    return (status === PackageStatusEnum.DISPOSABLE);
-  }
-
   backToList(): void {
     if (this.mode === AipMode.AIP) {
       this._store.dispatch(new Navigate([RoutesEnum.preservationPlanningAip + urlSeparator + this.storagion_number]));