fix: preservation error null pointer exceptions

src/app/features/preservation/job/components/presentationals/job-form/job-form.presentational.ts

@@ -74,13 +74,13 @@ export class JobFormPresentational extends SharedAbstractFormPresentational<Pres
     }
     this.form = this._fb.group({
       [this.formDefinition.name]: [preservationJob.name, [Validators.required, SolidifyValidator]],
-      [this.formDefinition.enable]: [preservationJob["enable"], [SolidifyValidator]],
+      [this.formDefinition.enable]: [preservationJob.enable, [SolidifyValidator]],
       [this.formDefinition.jobRecurrence]: [preservationJob.jobRecurrence, [Validators.required, SolidifyValidator]],
       [this.formDefinition.jobType]: [preservationJob.jobType, [Validators.required, SolidifyValidator]],
-      [this.formDefinition.hour]: [preservationJob.scheduling.hour, [Validators.min(0), Validators.max(23), SolidifyValidator]],
-      [this.formDefinition.weekDay]: [this.getWeekDay(isNullOrUndefined(preservationJob.scheduling.weekDay) ? undefined : preservationJob.scheduling.weekDay.toString()), [SolidifyValidator]],
+      [this.formDefinition.hour]: [this.getHours(preservationJob), [Validators.min(0), Validators.max(23), SolidifyValidator]],
+      [this.formDefinition.weekDay]: [this.getWeekDay(preservationJob), [SolidifyValidator]],
       [this.formDefinition.monthDay]: [scheduling.monthDay, [Validators.min(1), Validators.max(31), SolidifyValidator]],
-      [this.formDefinition.month]: [this.getMonth(isNullOrUndefined(preservationJob.scheduling.month) ? undefined : preservationJob.scheduling.month.toString()), [SolidifyValidator]],
+      [this.formDefinition.month]: [this.getMonth(preservationJob), [SolidifyValidator]],
     });
   }
 
@@ -121,19 +121,23 @@ export class JobFormPresentational extends SharedAbstractFormPresentational<Pres
     }
   }
 
-  private getMonth(id: string | undefined): string {
-    if (isNullOrUndefined(id)) {
-      return null;
+  private getHours(preservationJob: PreservationJob): number | undefined {
+    return isNullOrUndefined(preservationJob.scheduling) ? undefined : preservationJob.scheduling.hour;
+  }
+
+  private getMonth(preservationJob: PreservationJob): string {
+    if (isNullOrUndefined(preservationJob.scheduling) || isNullOrUndefined(preservationJob.scheduling.month)) {
+      return undefined;
     }
-    const month = JobHelper.getMonths().find(item => item.key === id);
+    const month = JobHelper.getMonths().find(item => item.key === "" + preservationJob.scheduling.month);
     return month === undefined ? null : month.key;
   }
 
-  private getWeekDay(id: string | undefined): string {
-    if (isNullOrUndefined(id)) {
-      return null;
+  private getWeekDay(preservationJob: PreservationJob): string {
+    if (isNullOrUndefined(preservationJob.scheduling) || isNullOrUndefined(preservationJob.scheduling.weekDay)) {
+      return undefined;
     }
-    const weekDay = JobHelper.getWeekDays().find(item => item.key === id);
+    const weekDay = JobHelper.getWeekDays().find(item => item.key === "" + preservationJob.scheduling.weekDay);
     return weekDay === undefined ? null : weekDay.key;
   }
 }

src/app/features/preservation/job/components/routables/job-detail-edit/job-detail-edit.routable.ts

@@ -75,7 +75,7 @@ export class JobDetailEditRoutable extends SharedAbstractDetailEditCommonRoutabl
         icon: "play_arrow",
         labelToTranslate: TRANSLATE("preservation.jobExecution.button.start"),
         callback: () => this.jobExecutionList.start(),
-        displayCondition: (resource) => resource && (resource.jobRecurrence !== JobRecurrenceEnum.ONCE || (this.jobExecutionList && !this.jobExecutionList.atLeastOneExecution)),
+        displayCondition: (resource) => !this.isEdit && resource && (resource.jobRecurrence !== JobRecurrenceEnum.ONCE || (this.jobExecutionList && !this.jobExecutionList.atLeastOneExecution)),
         order: 31,
       },
       {
@@ -83,6 +83,7 @@ export class JobDetailEditRoutable extends SharedAbstractDetailEditCommonRoutabl
         icon: "refresh",
         labelToTranslate: TRANSLATE("preservation.jobExecution.button.refresh"),
         callback: () => this.jobExecutionList.getAll(),
+        displayCondition: (resource) => !this.isEdit,
         order: 41,
       },
     ];