fix(contributors): [AoU-507] simplify contributors list synchronization and...

fix(contributors): [AoU-507] simplify contributors list synchronization and remove ORCID from contributor table

AoU-IntegrationTests/src/test/java/ch/unige/aou/test/admin/PublicationAsUserIT.java

@@ -714,6 +714,14 @@ class PublicationAsUserIT extends PublicationIT {
     /************************
      * Remove cnIndividu from first UNIGE contributor
      */
+
+    //check that the first contributor can be found
+    this.restClientTool.sudoRoot();
+    Contributor previousContributor = this.contributorService.findOne(contributor1.getResId());
+    this.restClientTool.exitSudo();
+    assertNotNull(previousContributor);
+    assertEquals(contributor1.getResId(), previousContributor.getResId());
+
     contributorDTOs.get(0).setCnIndividu(null);
 
     xmlMetadata = this.getMetadata(properties);
@@ -743,6 +751,12 @@ class PublicationAsUserIT extends PublicationIT {
     assertEquals(this.CONTRIBUTOR2_FIRSTNAME, updatedContributor2.getFirstName());
     assertEquals(this.CONTRIBUTOR2_LASTNAME, updatedContributor2.getLastName());
 
+    //check that the first contributor can not be found anymore:  he has been deleted as he was not linked to any other publication
+    this.restClientTool.sudoRoot();
+    previousContributor = this.contributorService.findOne(contributor1.getResId());
+    this.restClientTool.exitSudo();
+    assertNull(previousContributor);
+
     /************************
      * Make first contributor UNIGE member again --> must use the same existing contributor
      */
@@ -766,9 +780,7 @@ class PublicationAsUserIT extends PublicationIT {
     assertEquals(this.CONTRIBUTOR1_CN_INDIVIDU, updatedAgainContributor1.getCnIndividu());
     assertEquals(this.CONTRIBUTOR1_FIRSTNAME, updatedAgainContributor1.getFirstName());
     assertEquals(this.CONTRIBUTOR1_LASTNAME, updatedAgainContributor1.getLastName());
-    // check that the same UNIGE contributor has been used in database
-    assertEquals(contributor1.getResId(), updatedAgainContributor1.getResId());
-
+   
     assertTrue(updatedAgainContributorOptional2.isPresent());
     Contributor updatedAgainContributor2 = updatedAgainContributorOptional2.get();
     assertEquals(this.CONTRIBUTOR2_CN_INDIVIDU, updatedAgainContributor2.getCnIndividu());