Skip to content
Snippets Groups Projects

feat(ORCID): updating a missing ORCID Work do not always recreate a new one

Merged Nicolas.Rod requested to merge rodn-orcid-parameter-to-auto-recreate-work into master
3 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
72 73 }
73 74
74 75 public OrcidSynchronization sendToOrcidProfile(PersonWithOrcid person, String objectId) {
75 if (person.getOrcidToken() == null) {
76 return this.sendToOrcidProfile(person, objectId, false);
77 }
78
79 public OrcidSynchronization sendToOrcidProfile(PersonWithOrcid person, String objectId, boolean recreateIfMissingInProfile) {
  • 72 73 }
    73 74
    74 75 public OrcidSynchronization sendToOrcidProfile(PersonWithOrcid person, String objectId) {
  • 98 // Upload succeeded
    99 if (previousPutCode.equals(putCode)) {
    100 log.info("Object '{}' ({}) has been updated on ORCID profile of person {} as Work with putCode {}", work.getTitle().getTitle(),
    101 objectId, person, putCode);
    102 } else {
    103 log.info("Object '{}' ({}) has been created again on ORCID profile of person {} as Work with putCode {}", work.getTitle().getTitle(),
    104 objectId, person, putCode);
    105 }
    106
    107 // Upload succeeded, update OrcidSynchronization in database
    99 108 previousSynchronization.setPutCode(putCode);
    109 previousSynchronization.setUploadDate(OffsetDateTime.now());
    110 return this.save(previousSynchronization);
    111 } else {
    112 // Upload failed, do not update OrcidSynchronization in database
    113 return null;
  • Nicolas.Rod added 1 commit

    added 1 commit

    • 42744aac - do not return null but use SolidifyOrcidWorkMissingInProfileException +...

    Compare with previous version

  • Nicolas.Rod added 1 commit

    added 1 commit

    • 61bb6092 - do not return null but use SolidifyOrcidWorkMissingInProfileException +...

    Compare with previous version

  • Nicolas.Rod added 1 commit

    added 1 commit

    • bf5cff3c - do not return null but use SolidifyOrcidWorkMissingInProfileException +...

    Compare with previous version

  • Nicolas.Rod added 1 commit

    added 1 commit

    • af2f2854 - rename saveNewOrcidSynchronization method

    Compare with previous version

  • Please register or sign in to reply
    Loading