accessmod_replay_demo

Rollback of the original config.json file Slight modifications in the script.sh (docker image, no docker interactive session and launch R script)

requested review from @Frederic.Moser

assigned to @Frederic.Moser

marked this merge request as ready

closed

reopened

Thanks !

I forgot to remove --ti -rm and put back Rscript ... sorry :/

For the JSON file, could you resubmit a version with the correct formatting / indentation ?

A language server for JSON is included in VSCode, or with vim coc there is a coc-json. Or directly : https://www.npmjs.com/package/vscode-json-languageservice

You can also do a JSON.stringify(<obj>,0,2) in NodeJS or in your browser console (cheap hack), but I recommend doing that using proper text editor equipped with a language server.

If I merge your one line config, its a 100% diff change. Which defeats the purpose of git, which is based on line changes

Thanks again

Sorry. I modified the indentation. Thanks

added 1 commit

• cec0e3aa - json correct indentation

Compare with previous version

Almost there !

The original file was two spaces per indentation, e.g. JSON.stringify(<obj>,0,2) or better, the format tool in the languate tool mentioned, which is even more opinionated. The best is not to modify lines when it's not required, so you're safe.

Diff are important to help decide if there is no unexpected changes.

If you change one variable, but the whole file is rewritten, the reviewer has to either

1. trust you 100%
2. review each lines, one by one (600 lines = the afternoon)

Here is what I mean :

However, I will merge this as there are not direct implication, except messy diffs.

closed

reopened

approved this merge request

merged

mentioned in commit f580d3d7