Skip to content
Snippets Groups Projects

refactor[AOU-1940]: don't sync publication to orci that older than 1900

Merged refactor[AOU-1940]: don't sync publication to orci that older than 1900
aou-1940_dont_snyc_publication_older_than_1900 into master
1 unresolved thread
Merged Homada.Boumedane requested to merge aou-1940_dont_snyc_publication_older_than_1900 into master
1 unresolved thread

don't sync publication prior to 1900.

Closes: AOU-1940

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alicia.DeDiosFuente
  • Alicia.DeDiosFuente added 2 commits

    added 2 commits

    Compare with previous version

  • Alicia.DeDiosFuente assigned to @rodn and unassigned @Alicia.DeDiosFuente

    assigned to @rodn and unassigned @Alicia.DeDiosFuente

  • Nicolas.Rod added 2 commits

    added 2 commits

    Compare with previous version

  • Nicolas.Rod
    Nicolas.Rod @rodn started a thread on the diff
    • AoU-Admin/src/main/java/ch/unige/aou/service/metadata/MetadataExtractor.java
    760 760 this.depositDocAdapter.setLanguages(depositDocObj, languagesList);
    761 761 }
    762 762
    763 public Optional<Integer> getPublicationYear(Object depositDocObj) {
    764 Optional<MetadataDates> first = this.depositDocAdapter.getDates(depositDocObj).stream()
    • Nicolas.Rod
      Nicolas.Rod @rodn
      Owner

      Il faudrait utiliser la même logique que pour calculer "globalYear" dans CommonMetadataService: prendre DATE_TYPE_PUBLICATION si elle existe, ensuite DATE_TYPE_FIRST_ONLINE si elle existe, etc. (voir ligne 540 dans CommonMetadataService). Là le code prend la première date qui matche une de ces conditions.

    • Homada.Boumedane
      Homada.Boumedane @Homada.Boumedane
      Author Owner

      Le OR est la pour cela justement, si DATE_TYPE_FIRST_ONLINE existe elle sera prise sinon DATE_TYPE_FIRST_ONLINE etc ...

    • Please register or sign in to reply
  • Homada.Boumedane added 2 commits

    added 2 commits

    • 4891abf2 - fix: [AOU-1967] deposit with collaboration should not open automatically the...
    • 5698103d - refactor: orcid sync

    Compare with previous version

  • Homada.Boumedane added 3 commits

    added 3 commits

    Compare with previous version

  • Nicolas.Rod added 7 commits

    added 7 commits

    Compare with previous version

  • Nicolas.Rod merged

    merged

    • Please register or sign in to reply