Skip to content
Snippets Groups Projects

fix: use string values when generating conformanceStatus enum doc

1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • I just made a mvn clean package on master and for me the values are already fine in the generated doc:

      Values: approved, empty, not_reviewed, rejected

      Not sure if there is really anything to change ?

  • Okay, sorry, I didn't get it at first as I thought they were the correct values accepted by the endpoint.

    So I've built your branch to see what it gives, and I think this is not perfect neither:

    Values: approved, `, `not reviewed, rejected
  • Not sure where you are checking that specifically. I have checked the aou-api.json and the values are correct: "odConformance" : { "description" : "The OD conformance status", "enum" : [ "approved", "", "not reviewed", "rejected" ], "type" : "string" }, "osdConformance" : { "description" : "The OSD conformance status", "enum" : [ "approved", "", "not reviewed", "rejected" ], "type" : "string" },

    Screen_Shot_2020-11-18_at_15.10.51

    Then in the portail, it's interpreted as: Screen_Shot_2020-11-18_at_15.11.35

    Edited by Alicia.DeDiosFuente
  • The value I wrote is what we get in AoU-APIs.html and AoU-APIs.pdf. The empty string is probably not supported correctly when generating these files.

  • Nicolas.Rod added 7 commits

    added 7 commits

    Compare with previous version

  • merged

Please register or sign in to reply
Loading