Skip to content
Snippets Groups Projects

refacto(NotificationType): [AOU-543] simplify notification types and relation to subscribers

Merged Nicolas.Rod requested to merge rodn-543-clean-notification-types into master
1 unresolved thread
Edited by Nicolas.Rod

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
71 Notification createRemoteNotification(Notification localNotification) {
72 return this.notificationService.create(localNotification);
38 return publication;
73 39 }
74 40
75 void inboxTest(NotificationType notificationType, boolean shouldBeInInbox, boolean isInResearchGroup) {
76 final Notification localNotification = this.createLocalNotification(notificationType, isInResearchGroup);
77 final Notification remoteNotification = this.createRemoteNotification(localNotification);
78 final Notification inboxNotification = this.notificationService.getInboxNotification(remoteNotification.getResId());
79 assertEquals(inboxNotification != null, shouldBeInInbox, "Notification created should be in inbox");
80 if (shouldBeInInbox) {
81 final List<Notification> notificationList = this.notificationService.getInboxNotifications();
82 assertTrue(notificationList.size() >= 1, "There should be at least one notification in the inbox");
83 assertTrue(notificationList.stream().anyMatch(n -> n.getResId().equals(inboxNotification.getResId())),
84 "There should be a least one notification with id= "+ inboxNotification.getResId());
41 protected Notification getLastNotificationForCurrentUser() {
  • Nicolas.Rod added 6 commits

    added 6 commits

    • cb624483...9ac52d46 - 4 commits from branch master
    • 690dc2bf - refacto(NotificationType): [AOU-543] simplify notification types and relation to subscribers
    • 27eee600 - fix(NotificationDoc): set recipient resId to allow building

    Compare with previous version

  • Nicolas.Rod added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas.Rod added 1 commit

    added 1 commit

    • 731a048d - fix(NotificationService): remove not used repository

    Compare with previous version

  • Please register or sign in to reply
    Loading