Skip to content
Snippets Groups Projects

show delete button file input by default

Closed show delete button file input by default
hedera-128_delete_button_not_showing into master
2 unresolved threads
Closed Homada.Boumedane requested to merge hedera-128_delete_button_not_showing into master
2 unresolved threads

show delete button by default.

Closes HEDERA-128

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
projects/solidify-frontend/src/lib/input/containers/file-upload-input/file-upload-input.container.ts
450 450 fileExtension: FileVisualizerHelper.getFileExtension(this.internalFile.name),
451 451 });
452 452 }
453
454 protected readonly isNotNullNorUndefined = isNotNullNorUndefined;
  • Florent Poittevin
    Florent Poittevin @Florent.Poittevin started a thread on the diff
    • projects/solidify-frontend/src/lib/input/containers/file-upload-input/file-upload-input.container.ts
    233 233 }
    234 234
    235 235 get displayDeleteButton(): boolean {
    236 return !this.readonly && isNotNullNorUndefined(this.internalFile) && this.allowDelete;
    236 return this.readonly && isNotNullNorUndefined(this.internalFile) && this.allowDelete;
    • Florent Poittevin
      Florent Poittevin @Florent.Poittevin
      Developer

      Du coup avec ce changement on affiche le bouton uniquement si le composant est en readonly ?!

      Justement si c'est en readonly on ne doit pouvoir faire aucun changement sur le fichier.

      Il faut regarder dans le contexte d'utilisation de ce composant, pour faire en sorte que readonly ne soit pas true afin que tu puisses supprimer le fichier (et vérifier que ton input allowDelete soit bien à true (c'est sa valeur par défaut))

    • Please register or sign in to reply
  • Florent Poittevin closed

    closed

    • Please register or sign in to reply